Content-Length: 239776 | pFad | https://github.com/apex/up/pull/672

AD docs: Fix default stage of "up" and "up deploy" by philippgille · Pull Request #672 · apex/up · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix default stage of "up" and "up deploy" #672

Merged
merged 1 commit into from
Jun 3, 2018

Conversation

philippgille
Copy link
Contributor

According to other parts of the documentation and also according to the code the default stage is "staging" and not "development".
See code at latest commit for that file:

stage := cmd.Arg("stage", "Target stage name.").Default("staging").String()

Note: Only the PR header contains the "docs: " prefix. Is this enough for the filtering of the release notes, or do I need to change the commit?

According to other parts of the documentation and also according to the code the default stage is "staging" and not "development".
See code at latest commit for that file: https://github.com/apex/up/blob/6d27f34c95c7eeba660d54a8ff7c6e48c69f6769/internal/cli/deploy/deploy.go#L22
@CLAassistant
Copy link

CLAassistant commented Jun 3, 2018

CLA assistant check
All committers have signed the CLA.

@tj
Copy link
Member

tj commented Jun 3, 2018

oh crazy, thought I fixed that, thanks!

@tj tj merged commit 071a6f1 into apex:master Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/apex/up/pull/672

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy