UITextContentType support in InputField #542
Conversation
|
@ejensen Thanks, looks good at a glance. Will schedule some time to review later today. Good to see you fixed for Swift 3. I would ask that you document any changes to the Public API in the description as requested when creating a PR. Such as changes to |
|
Also any before/after screenshots also great to have. |
I've updated this PR's description as well as added a commit to update the example project and README with the new arguments for |
| @@ -212,6 +200,18 @@ func applyDefaultOptions(_ options: inout OptionBuildable) { | |||
| options.loggerOutput = CleanroomLockLogger() | |||
| options.logHttpRequest = true | |||
| options.oidcConformant = true | |||
|
|
|||
| if #available(iOS 10, *) { | |||
There was a problem hiding this comment.
Don't usually accept changes to the Test App. However, this looks fine. Passwordless will be untouched as it doesn't use CustomTextFields.
Changes
Assigns the appropriate
UITextContentTypebased onInputField.InputType.Assigning the content type of the text field allows iOS to better match auto-fill values.
Public API Changes
contentType: UITextContentType?argument was added toCustomTextField.initBefore and After
References
UITextInputTraits.textContentTypeUITextContentTypeTesting
Checklist