Expose onForgotPassword [SDK-2632] #673
Conversation
There was a problem hiding this comment.
While there's a constant defined for the event, Lock Android does not invoke the callback when the "send password reset" request was successful. See here: https://github.com/auth0/Lock.Android/blob/main/lib/src/main/java/com/auth0/android/lock/LockActivity.java#L575-L583.
I know there are disparities when we invoke the callbacks between these two platforms, so I'm not going to block this change. But bear in mind that merging this would contribute to adding more differences.
This change cannot be added in a non-breaking way to the current Lock Android major.
|
@lbalmaceda why is the event defined but not used? |
|
@Widcket Not sure why that event was never used internally in Android. Let's take a day or two to revisit the differences between both platforms in terms of callbacks and event handling and come back with an outcome we can share. |
Changes
This PR exposes in the public API the
onForgotPasswordcallback that was implemented and had unit tests, but could not be used as there was no public API for it.Implementation
Lock.swift/Lock/ObserverStore.swift
Line 60 in a13bb76
Unit tests
https://github.com/auth0/Lock.swift/blob/master/LockTests/Models/ObserverStoreSpec.swift#L79
https://github.com/auth0/Lock.swift/blob/master/LockTests/Models/ObserverStoreSpec.swift#L149
https://github.com/auth0/Lock.swift/blob/master/LockTests/Models/ObserverStoreSpec.swift#L154
https://github.com/auth0/Lock.swift/blob/master/LockTests/Models/ObserverStoreSpec.swift#L163
Screen.Recording.2021-07-01.at.20.51.08.mov
References
Fixes #666
Lock.Android exposes a
RESET_PASSWORDevent: https://github.com/auth0/Lock.Android/blob/main/lib/src/main/java/com/auth0/android/lock/LockCallback.java#L56Testing
The callback has unit tests, but it was also tested manually using an iPhone simulator. A unit test covering the new public API method was also added.
Checklist