Allow v8 to allocate more heap #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow. I am surprised that this is necessary. Thanks. |
rix0rrr
approved these changes
Dec 12, 2018
eladb
approved these changes
Dec 12, 2018
|
Please hold on merging - there are more cases where v8 is running out of memory, for example, when building modules. More patches forthcoming. |
otterley
force-pushed
the
fix_mem_exhaustion
branch
2 times, most recently
from
8353e1b to
a79d727
Compare
|
OK, I've updated all the scripts I could find that invoke |
RomainMuller
approved these changes
Dec 14, 2018
build.sh
Outdated
| @@ -41,6 +41,7 @@ BUILD_INDICATOR=".BUILD_COMPLETED" | |||
| rm -rf $BUILD_INDICATOR | |||
|
|
|||
| export PATH=node_modules/.bin:$PATH | |||
| export NODE_OPTIONS="--max-old-space-size=4096" | |||
There was a problem hiding this comment.
If possible, I'd like those to be additive:
export NODE_OPTIONS="--max-old-space-size=4096 ${NODE_OPTIONS}"
a79d727 to
9efe413
Compare
otterley
force-pushed
the
fix_mem_exhaustion
branch
4 times, most recently
from
708f29e to
9379d5d
Compare
Prevent out-of-memory errors encountered during `lerna bootstrap` on certain systems by allowing Node's v8 engine to allocate more heap. The default, even on 64-bit architectures, is too small (1.4GB) to complete compilation successfully, so we set it to 4GB for the bootstrap phase.
otterley
force-pushed
the
fix_mem_exhaustion
branch
from
9379d5d to
4bf6938
Compare
|
@RomainMuller Addressed your issues - PTAL |
|
@otterley awesome! Thank you very much!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent out-of-memory errors encountered during
lerna bootstraponcertain systems by allowing Node's v8 engine to allocate more heap. The
default, even on 64-bit architectures, is too small (1.4GB) to
complete compilation successfully, so we set it to 4GB for the bootstrap
phase.
Fixes #1335
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.