Content-Length: 296715 | pFad | https://github.com/aws/graph-explorer/pull/352

92 Update React to v18 by kmcginnes · Pull Request #352 · aws/graph-explorer · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React to v18 #352

Merged
merged 10 commits into from
May 3, 2024
Merged

Update React to v18 #352

merged 10 commits into from
May 3, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented May 3, 2024

Description

  • Updates React to v18
    • Changed root render calls to the new style
    • Fixed stricter type requirements
    • Moved off deprecated types
    • Fixed key prop being set by object spreading
  • Updates all React components to latest
    • Mantine jumped two versions and needed adjustments
    • The drag and drop lib react-dnd needed some slight adjustments
  • Fixed existing issue exposed by the React v18 upgrade of a runaway useEffect that fires way too often
    • Moved the logic in to a component that is conditionally shown so that the useEffect is no longer necessary. The state that was updated is set when the component is shown, which is all that is needed.

Validation

Essentially, nothing should change from a user's perspective. This is purely a regression test.

  • Test within Sagemaker Notebook before merging

Focus On

  • Modals
  • File inputs
  • Export from table (nodes and edges)
  • Drag and drop (search results to graph, connection file to connections)

Review Suggestions

Given the size of this change set, I would recommend reviewing the code changes commit by commit. It may also be useful to enable the "hide whitespace" in GitHub.

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@kmcginnes kmcginnes requested a review from vkagamlyk May 3, 2024 16:58
@kmcginnes kmcginnes modified the milestone: Release 1.6.1 May 3, 2024
@kmcginnes kmcginnes marked this pull request as ready for review May 3, 2024 17:02
Copy link
Contributor

@vkagamlyk vkagamlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmcginnes kmcginnes merged commit fb5ef49 into aws:main May 3, 2024
2 checks passed
@kmcginnes kmcginnes deleted the update-react branch May 3, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update React to v18 Update React components to latest [Feature Request] Update React version
2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/aws/graph-explorer/pull/352

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy