Content-Length: 292234 | pFad | https://github.com/aws/graph-explorer/pull/419

E3 Extract views to simpler components by kmcginnes · Pull Request #419 · aws/graph-explorer · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract views to simpler components #419

Merged
merged 2 commits into from
May 29, 2024
Merged

Extract views to simpler components #419

merged 2 commits into from
May 29, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented May 28, 2024 •
edited by michaelnchin
Loading

Description

Refactors a few views in to simpler components to make the structure easier to understand.

No logic is actually changed. This is just moving some code around.

Validation

  • Add a node and expand
  • Change selection
  • Show legend

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@codecov Codecov
Copy link

codecov bot commented May 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 187 lines in your changes are missing coverage. Please review.

Project coverage is 14.90%. Comparing base (361c4ba) to head (62eaa77).
Report is 23 commits behind head on main.

❗ Current head 62eaa77 differs from pull request most recent head 9d75e97

Please upload reports for the commit 9d75e97 to get more accurate results.

Files Patch % Lines
...lorer/src/modules/NodeExpand/NodeExpandContent.tsx 0.00% 134 Missing ⚠️
...h-explorer/src/modules/GraphViewer/GraphViewer.tsx 0.00% 53 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   13.97%   14.90%   +0.92%     
==========================================
  Files         414      416       +2     
  Lines       30639    30860     +221     
  Branches      878      952      +74     
==========================================
+ Hits         4283     4600     +317     
+ Misses      26026    25931      -95     
+ Partials      330      329       -1
Flag Coverage Δ
unittests 14.90% <0.00%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmcginnes kmcginnes marked this pull request as ready for review May 28, 2024 22:04
michaelnchin
michaelnchin previously approved these changes May 29, 2024
View reviewed changes
@michaelnchin michaelnchin merged commit 6736398 into aws:main May 29, 2024
1 check passed
@kmcginnes kmcginnes deleted the refactor-views branch May 29, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cubeddu cubeddu cubeddu approved these changes

@michaelnchin michaelnchin michaelnchin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmcginnes @michaelnchin @cubeddu








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/aws/graph-explorer/pull/419

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy