Content-Length: 277094 | pFad | https://github.com/aws/graph-explorer/pull/669

1D Open search by default by kmcginnes · Pull Request #669 · aws/graph-explorer · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open search by default #669

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Nov 12, 2024

Description

New users should see the search sidebar open by default when they launch for the first time.

  • Adjusted add and remove buttons for search results
    • Use primary button colors for both add and remove
    • Change remove icon to circle with minus
    • Add tooltip
  • Made search sidebar open by default for new users
  • Add padding to empty states in connection screen

Validation

  • Verified locally by deleting my local graph explorer database to simulate a new user

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review November 12, 2024 17:35
@kmcginnes kmcginnes marked this pull request as draft November 12, 2024 18:18
@kmcginnes kmcginnes marked this pull request as ready for review November 12, 2024 20:28
@kmcginnes
Copy link
Collaborator Author

Updated based on feedback:

  • Changed "Remove from graph" button icon to a circle with a minus sign to match with the plus
  • Changed color to standard primary
  • Added tooltip for both add and remove buttons

image

Copy link

@Cole-Greer Cole-Greer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kmcginnes kmcginnes merged commit 4a79bc4 into aws:main Nov 12, 2024
1 check passed
@kmcginnes kmcginnes deleted the open-search-by-default branch November 12, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/aws/graph-explorer/pull/669

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy