-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recover from exported using
declaration
#16407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Polish 💅
A type of pull request used for our changelog categories
area: errors
labels
Apr 3, 2024
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56658 |
liuxingbaoyu
approved these changes
Apr 3, 2024
nicolo-ribaudo
approved these changes
Apr 3, 2024
nicolo-ribaudo
changed the title
Recover from exported using declaration
Recover from exported Apr 4, 2024
using
declaration
This was referenced May 20, 2024
This was referenced May 20, 2024
This was referenced Jul 2, 2024
This was referenced Jul 3, 2024
Open
This was referenced Jul 4, 2024
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Jul 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: errors
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
pkg: parser
PR: Polish 💅
A type of pull request used for our changelog categories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the parser now recovers from the invalid
export using x = ...
production, as I assume it might be a common scenario when people try to export a using declaration as if it were a normal constant variable.