Content-Length: 402454 | pFad | https://github.com/babel/babel/pull/16658

F9 Move `ensureFunctionName` to `NodePath.prototype` by nicolo-ribaudo · Pull Request #16658 · babel/babel · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ensureFunctionName to NodePath.prototype #16658

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Move ensureFunctionName to NodePath.prototype #16658

merged 3 commits into from
Jul 26, 2024

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 17, 2024 •
edited
Loading

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This should be the last non-peerDependencies cycle between packages :)

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: traverse labels Jul 17, 2024
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 17, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57471

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jul 17, 2024
Merged
@nicolo-ribaudo nicolo-ribaudo added this to the v7.25.0 milestone Jul 17, 2024
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jul 17, 2024
Merged
4 tasks
@nicolo-ribaudo nicolo-ribaudo requested a review from JLHwung July 25, 2024 18:50
@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.25.0/remove-cycles branch 2 times, most recently from bcac3c8 to 62b12b0 Compare July 26, 2024 10:30
@nicolo-ribaudo nicolo-ribaudo deleted the branch babel:main July 26, 2024 12:21
@nicolo-ribaudo nicolo-ribaudo changed the base branch from feat-7.25.0/remove-cycles to main July 26, 2024 12:22
@nicolo-ribaudo nicolo-ribaudo merged commit d364545 into babel:main Jul 26, 2024
51 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the remove-cycles-4 branch July 26, 2024 15:58
@mikevoets
Copy link

Hello, because of this change we're seeing a breaking change: value.ensureFunctionName is not a function.

Can you please let us know how we fix this?

@mikevoets mikevoets mentioned this pull request Jul 28, 2024
Closed
1 task
This was referenced Aug 16, 2024
Open
Open
@ashly1111111 ashly1111111 mentioned this pull request Aug 16, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Aug 16, 2024
Open
This was referenced Oct 29, 2024
Open
Open
Open
Open
Open
@nejidevelops nejidevelops mentioned this pull request Oct 29, 2024
Open
@ali8889 ali8889 mentioned this pull request Oct 30, 2024
Open
This was referenced Oct 30, 2024
Closed
Closed
@tiff-es tiff-es mentioned this pull request Oct 30, 2024
Open
@syofyanzuhad syofyanzuhad mentioned this pull request Oct 30, 2024
Open
@anandgupta193 anandgupta193 mentioned this pull request Oct 30, 2024
Open
@mastudillot mastudillot mentioned this pull request Oct 30, 2024
Merged
@lholmquist lholmquist mentioned this pull request Oct 30, 2024
Open
@DevangPatelUK DevangPatelUK mentioned this pull request Oct 30, 2024
Open
@junInUK junInUK mentioned this pull request Oct 31, 2024
Open
@bee22193 bee22193 mentioned this pull request Oct 31, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Oct 31, 2024
Open
This was referenced Oct 31, 2024
Open
Open
Open
Open
Open
@NOUIY NOUIY mentioned this pull request Oct 31, 2024
Open
@basharat-j basharat-j mentioned this pull request Nov 1, 2024
Open
@YoYBaBy YoYBaBy mentioned this pull request Nov 1, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 2, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Nov 2, 2024
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Milestone
v7.25.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolo-ribaudo @babel-bot @mikevoets @JLHwung @liuxingbaoyu








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/babel/babel/pull/16658

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy