This repository was archived by the owner on Jan 30, 2020. It is now read-only.
functional: close DBUS connections after running systemd commands #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsupark
force-pushed
the
dongsu/dbus-conn-close-fxtests
branch
from
f7d136f to
a0e0ef6
Compare
As described in coreos#1704, functional test has a bug hitting an upper limit of ~40 tests in total. That's actually an issue of DBUS connections remaining opened even after nspawn containers got successfully terminated. That's why the number of unix sockets grows up to 256. $ netstat -nap | grep /var/run/dbus/system_bus_socket | wc -l 256 From that moment on, functional test hangs mysteriously. Sometimes users could see errors like "The maximum number of active connections for UID 0 has been reached." Its reason is that every DBUS connection was never closed. The more tests we add, the more stale DBUS connections we have. This bug has existed since the beginning. Fix it by adding conn.Close() after running systemd commands.
dongsupark
force-pushed
the
dongsu/dbus-conn-close-fxtests
branch
from
a0e0ef6 to
951c99f
Compare
|
As it's clearly a bug, and it doesn't affect main code, I'll simply merge. |
|
nice catch! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1704, functional test has a bug hitting an upper limit of ~40 tests in total. That's actually an issue of DBUS connections remaining opened even after nspawn containers got successfully terminated. That's why the number of unix sockets grows up to 256.
From that moment on, functional test hangs mysteriously. Sometimes users could see errors like
"The maximum number of active connections for UID 0 has been reached."Its reason is that every DBUS connection was never closed. The more tests we add, the more stale DBUS connections we have. This bug has existed since the beginning.
Fix it by adding
conn.Close()after running systemd commands.