Content-Length: 443343 | pFad | https://github.com/cvg/limap/pull/103

DB Move third parties to requirements.txt. Add end-to-end tests to CI by B1ueber2y · Pull Request #103 · cvg/limap · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move third parties to requirements.txt. Add end-to-end tests to CI #103

Merged
merged 123 commits into from
Nov 29, 2024
Merged

Move third parties to requirements.txt. Add end-to-end tests to CI #103

merged 123 commits into from
Nov 29, 2024

Conversation

B1ueber2y
Copy link
Member

@B1ueber2y B1ueber2y commented Nov 29, 2024 •
edited
Loading

Now we only support Python up to 3.10 because of open3d==0.16.0.

The wheels are still currently blocked due to the following two reasons (will look into it in later PR when I get more time):

  • hloc needs to be installed with edit mode (otherwise it will hit "ModuleNotFoundError: No module named 'SuperGluePretrainedNetwork.models'")
  • ceres was built with dynamic links in the CI machine

B1ueber2y added 30 commits August 26, 2024 01:02
@B1ueber2y B1ueber2y changed the title Move third parties to requirements.txt. Add end-to-end CI test Move third parties to requirements.txt. Add end-to-end test to CI Nov 29, 2024
@B1ueber2y B1ueber2y changed the title Move third parties to requirements.txt. Add end-to-end test to CI Move third parties to requirements.txt. Add end-to-end tests to CI Nov 29, 2024
@B1ueber2y B1ueber2y marked this pull request as draft November 29, 2024 02:26
@B1ueber2y B1ueber2y marked this pull request as ready for review November 29, 2024 10:21
@B1ueber2y B1ueber2y merged commit 9048e7e into main Nov 29, 2024
4 checks passed
@B1ueber2y B1ueber2y deleted the features/e2e_test branch November 29, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpautrat rpautrat rpautrat approved these changes

@MarkYu98 MarkYu98 Awaiting requested review from MarkYu98 MarkYu98 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@B1ueber2y @rpautrat








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/cvg/limap/pull/103

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy