Content-Length: 337156 | pFad | https://github.com/desktop/desktop/issues/17120

A6 Add support for Pulsar code editor on Windows by confused-Techie · Pull Request #17120 · desktop/desktop · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Pulsar code editor on Windows #17120

Merged
merged 8 commits into from
Aug 4, 2023
Merged

Add support for Pulsar code editor on Windows #17120

merged 8 commits into from
Aug 4, 2023

Conversation

confused-Techie
Copy link
Contributor

Description

Adds support for the Pulsar code editor on Windows. A follow-up to #16220

Screenshots

image

Release notes

  • [Added] Add support for Pulsar code editor on Windows

Notes:

Apologies if my commit history is a little messy. But hopefully it's not an issue, thanks a ton to anyone who is able to take a look at this!

@confused-Techie confused-Techie mentioned this pull request Jul 26, 2023
Closed
1 task
sergiou87
sergiou87 previously approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@sergiou87 sergiou87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thank you for your contribution! 💖

@sergiou87 sergiou87 enabled auto-merge August 3, 2023 08:23
@sergiou87
Copy link
Member

sergiou87 commented Aug 3, 2023 •
edited
Loading

@confused-Techie could you please rebase update this PR with the latest development? #17078 changed the displayNamePrefix attribute to displayNamePrefixes, so I think this PR needs to adapt to that… sorry! 😅

@sergiou87 sergiou87 disabled auto-merge August 3, 2023 14:14
@confused-Techie
Copy link
Contributor Author

@confused-Techie could you please rebase update this PR with the latest development? #17078 changed the displayNamePrefix attribute to displayNamePrefixes, so I think this PR needs to adapt to that… sorry! 😅

Absolutely, I'll be able to get to this later today. Thanks a ton for reviewing my PR!

@confused-Techie
Copy link
Contributor Author

@sergiou87 as requested, I've updated this PR to reflect the new changes upstream, and merged all changes upstream here, to hopefully ensures tests pass as expected.

Again thanks a ton for spending your time on this one

@sergiou87 sergiou87 merged commit bc69ee8 into desktop:development Aug 4, 2023
@confused-Techie confused-Techie mentioned this pull request Aug 23, 2023
Merged
@Daeraxa Daeraxa mentioned this pull request Sep 15, 2023
Merged
@tidy-dev tidy-dev mentioned this pull request Nov 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiou87 sergiou87 sergiou87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@confused-Techie @sergiou87








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/desktop/desktop/issues/17120

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy