Theme radio buttons refactor #16525
Merged
Theme radio buttons refactor #16525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
changed the title
tidy-dev
commented
Apr 13, 2023
sergiou87
reviewed
Apr 14, 2023
sergiou87
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Code looks good and it works great! ✨ 
✨
The only thing that I would tweak is the size of the new "theme icons" to make them smaller, because right now this makes the Appearance section a bit taller than the rest, which feels like a step back from #16313
But given we want to deploy a beta build with this, I think that change can be made in a different PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: https://github.com/github/accessibility-audits/issues/3273
Description
This PR updates the theme selector to look like radio buttons.
This PR:
RadioGroupcomponent that we will likely need to wrap most of radio button usages with anyways because they should be in radio groups but are not currently.RadioGroupcomponent in theAppearancesettings and adds custom styling to mimic dotcom's theme selection..Screenshots
Release notes
Notes: [Improved] Make radio theme selection look like radio buttons.