This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
Respect configured host in bindings #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting ASPNETCORE_URLS env variable in ProcessRunner. This makes it possible to override which interface to bind to and also allow connections from anywhere by using a wildcard.
|
@veloek In general, looks good. The only thing I've noticed in testing is that, while |
|
@philliphoff, good catch! Didn't try running my services in Docker containers, but it makes sense to fix that as well while at it 👍 |
|
@philliphoff LGTM. If I were to nitpick, I see you use capital S in |
|
Ah, the hazards of owning codebases with entirely different style guides. :-) |
ravipal
approved these changes
Jan 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting ASPNETCORE_URLS env variable in ProcessRunner. This makes it possible to override which interface to bind to and also allow connections from anywhere by using a wildcard.
This is only tested for services configured as projects. Not sure how this affects other aspects of Tye.
Fixes #721