using the ASP.NET Core HealthChecks library for the liveness/readiness sample #523
Conversation
docs/recipes/probes.md
Outdated
| .AddCheck("someReadinessCheck", new MyGenericCheck(_statusDictionary, "someReadinessCheck"), failureStatus: HealthStatus.Unhealthy, tags: new[] { "readiness" }); | ||
| ``` | ||
|
|
||
| (Starting .NET 5, the HealthChecks library ships together with ASP.NET Core) |
There was a problem hiding this comment.
I believe this package has been shipping since 2.2. I'm not sure if we are shipping the HealthChecks library with ASP.NET Core though.
There was a problem hiding this comment.
you're right. I saw that the HealthChecks library moved to the aspnetcore repository after .NET 5, but it has been and still part of the extensions library.
|
Thanks for the doc! I think we should leave the readiness check and liveness check as fake checks that don't change as a result of an http request. It's fine in a sample but I would leave it out of the doc since it's not exactly what you would do in practice. |
|
@davidfowl I removed the whole talk about the |
|
LGTM, thanks! |
As discussed in #502