This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
fix #666, enable dotnet watch to refresh on razer file changes #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hossambarakat
requested review from
davidfowl,
jkotalik,
JunTaoLuo and
rynowak
as code owners
jkotalik
reviewed
Dec 1, 2020
| @@ -26,6 +26,7 @@ Returns: @(Watch) | |||
| </_CollectWatchItemsDependsOn> | |||
| <_CollectWatchItemsDependsOn Condition=" '$(TargetFramework)' != '' "> | |||
| _CoreCollectWatchItems; | |||
| $(CustomCollectWatchItems); | |||
There was a problem hiding this comment.
@pranavkm we should potentially talk about this; we copied the dotnet watch code into tye, and made a few modifications to instead run the executable rather than calling dotnet run. Is there any unification we could consider here?
There was a problem hiding this comment.
VS scans for dotnet-watch assets in the SDK. Is this something we could do with Tye? Alternatively we could always ship a sources packages to make sure we're in sync.
jkotalik
approved these changes
Dec 1, 2020
jkotalik
approved these changes
Dec 1, 2020
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the DotNetWatch.targets to include the razor files