-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pimoroni inkyWhat (Red, Black, White) EPD #7
Conversation
Hi Aaron, thank you for your pull request! I'll hopefully have some time tomorrow to take a look at it and get back to you if something pops up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes! Thank you for extending supported displays!
Please address the comments below
Thanks @dr-mod & @vindexins for the review. I think I have made changes to address most if not all of your concerns. I did hit an error when I ran it configured with a different screen than what I own and I don't know if I introduced the error or if it is because I don't have the correct library and/or hardware. |
Adding InkyWhat library to readme
Hi @martinatime, I've just got around to execute this on my pi and there are two things that I've noticed.
Will you be able to take a look at the latter please? |
I'll look into it this weekend. |
Great, thanks for looking into it. |
I had a little time tonight and it was bugging me. Please review it again and make sure it works on your hardware. Thanks again. |
Hey @martinatime , I've come round to double check it, tanks for updating your PR. There is a couple of things that need fixing. Let me do the following, I'll merge the PR now and fix it there, feel free to check if everything works afterwards. |
Got the inkyWhat RBW working as a new screen type. Changed the ploy.py which may affect other screens but I couldn't test as I don't have those.
https://shop.pimoroni.com/products/inky-what?variant=13590497624147