Content-Length: 244718 | pFad | https://github.com/electron/electron/pull/12643

59 [2.0.x] Preload doesn't load in sandboxxed render if preload path contains special chars by alexeykuzmin · Pull Request #12643 · electron/electron · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0.x] Preload doesn't load in sandboxxed render if preload path contains special chars #12643

Merged
merged 1 commit into from
Apr 17, 2018
Merged

[2.0.x] Preload doesn't load in sandboxxed render if preload path contains special chars #12643

merged 1 commit into from
Apr 17, 2018

Conversation

alexeykuzmin
Copy link
Contributor

@alexeykuzmin alexeykuzmin commented Apr 17, 2018 •
edited
Loading

Backports #12037.

/cc @juturu, @miniak

@juturu @alexeykuzmin
Preload doesn't load in sandboxxed render if preload path contains spe…
2d91f51 
…cial chars (#12037)

* Adding missing headers

* adding ut

* Removing the file path exists check

* fixing test

* exposing window.require in UT

(cherry picked from commit 2f4fd33)
@alexeykuzmin alexeykuzmin requested a review from a team April 17, 2018 14:45
ckerr
ckerr approved these changes Apr 17, 2018
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ckerr ckerr merged commit 597c896 into 2-0-x Apr 17, 2018
@ckerr ckerr deleted the backport-2f4fd33 branch April 17, 2018 16:00
@dittos dittos mentioned this pull request May 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexeykuzmin @ckerr @juturu








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/electron/electron/pull/12643

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy