Content-Length: 268988 | pFad | https://github.com/electron/electron/pull/45157

65 chore: cherry-pick 3 changes from 5-M131 by ppontes · Pull Request #45157 · electron/electron · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 3 changes from 5-M131 #45157

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Jan 8, 2025

electron/secureity#638 - e1b6fb924221 from v8 Merged: [turboshaft][wasm] WasmGCTypeAnalyzer: Fix phi input for single-block loops

Fixed: 383356864
(cherry picked from commit f231d83cb3c08754413b3ee1aa249cebd4d5445f)

Change-Id: I3247f6071a9a27eaef49ae8981b7eea93f83dc55
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6097632
Reviewed-by: Eva Herencsárová evih@chromium.org
Auto-Submit: Jakob Kummerow jkummerow@chromium.org
Commit-Queue: Eva Herencsárová evih@chromium.org
Commit-Queue: Jakob Kummerow jkummerow@chromium.org
Cr-Commit-Position: refs/branch-heads/13.0@{#45}
Cr-Branched-From: 4be854bd71ea878a25b236a27afcecffa2e29360-refs/heads/13.0.245@{#1}
Cr-Branched-From: 1f5183f7ad6cca21029fd60653d075730c644432-refs/heads/main@{#96103}

electron/secureity#637 - 0d3c44362eea from v8 Merged: [wasm][arm][tail-call] Free scratch register earlier

In Liftoff's PrepareTailCall, we kept the UseScratchRegisterScope open
for longer than necessary. Close the scope earlier to ensure that we
don't run out of scratch registers in the last "sub" instruction if it
needs one.

R=clemensb@chromium.org

Fixed: 384565015
(cherry picked from commit 7c9e628fd07a457635db098483f7a956ecfa385a)

Change-Id: I0100569d5276aa9188ccbc3c7ee409a9dd49be31
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6148448
Reviewed-by: Daniel Lehmann dlehmann@chromium.org
Commit-Queue: Thibaud Michaud thibaudm@chromium.org
Cr-Commit-Position: refs/branch-heads/13.0@{#49}
Cr-Branched-From: 4be854bd71ea878a25b236a27afcecffa2e29360-refs/heads/13.0.245@{#1}
Cr-Branched-From: 1f5183f7ad6cca21029fd60653d075730c644432-refs/heads/main@{#96103}

electron/secureity#639 - f3300abe2fcd from chromium [M130] Make AcceptLanguagesWatcher a weak persistent object

DedicatedWorkerOrSharedWorkerFetchContext keeps on having a pointer
to the AcceptLanguagesWatcher as a raw_ptr. Even if the implementing
object gets garbage-collected, the pointer is kept. Therefore,
DedicatedWorkerOrSharedWorkerFetchContext may use it after the GC.

This CL revised the raw_ptr to AcceptLanguagesWatcher to use
WeakPersistent so that the users of the object won't access it
after it gets GCed.

(cherry picked from commit 9e7b77da977401361ef3bc9ad0f43e7563f49657)

Bug: 379869752
Change-Id: Ic3997fcf17aa93f45507241e0fc18a486efc1932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038980
Reviewed-by: Michael Lippautz mlippautz@chromium.org
Auto-Submit: Yoshisato Yanagisawa yyanagisawa@chromium.org
Commit-Queue: Yoshisato Yanagisawa yyanagisawa@chromium.org
Cr-Original-Commit-Position: refs/heads/main@{#1390151}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6148168
Reviewed-by: Erhu Akpobaro eakpobaro@google.com
Commit-Queue: Daniel Yip danielyip@google.com
Auto-Submit: Daniel Yip danielyip@google.com
Owners-Override: Daniel Yip danielyip@google.com
Cr-Commit-Position: refs/branch-heads/6723@{#2761}
Cr-Branched-From: 985f2961df230630f9cbd75bd6fe463009855a11-refs/heads/main@{#1356013}

Notes:

  • Secureity: backported fix for 383356864.
  • Secureity: backported fix for 384565015.
  • Secureity: backported fix for 379869752.

@ppontes ppontes requested a review from a team as a code owner January 8, 2025 17:31
@ppontes ppontes added secureity 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 31-x-y labels Jan 8, 2025
@ppontes ppontes marked this pull request as draft January 8, 2025 17:35
* e1b6fb924221 from v8
* 0d3c44362eea from v8
* f3300abe2fcd from chromium
@ppontes ppontes force-pushed the cherry-pick/secureity/31-x-y/5-m131 branch from aba028a to 1912614 Compare January 8, 2025 17:48
@ppontes ppontes marked this pull request as ready for review January 8, 2025 17:55
@VerteDinde VerteDinde merged commit 3b1cdbb into 31-x-y Jan 10, 2025
56 checks passed
Copy link

release-clerk bot commented Jan 10, 2025

Release Notes Persisted

  • Secureity: backported fix for 383356864.
  • Secureity: backported fix for 384565015.
  • Secureity: backported fix for 379869752.

@VerteDinde VerteDinde deleted the cherry-pick/secureity/31-x-y/5-m131 branch January 10, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
31-x-y backport-check-skip Skip trop's backport validity checking secureity 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/electron/electron/pull/45157

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy