Content-Length: 239034 | pFad | https://github.com/fastplotlib/fastplotlib/pull/323

45 fix cmap_values were not set in the `@setter` by kushalkolar · Pull Request #323 · fastplotlib/fastplotlib · GitHub

fix cmap_values were not set in the `@setter` #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kushalkolar merged 1 commit into master from fix-line-collection-cmap-values-setter

Oct 14, 2023

Member

kushalkolar commented Oct 14, 2023

This snuck by, our tests aren't actually checking the @setter:
https://github.com/fastplotlib/fastplotlib/blob/master/examples/desktop/line_collection/line_collection_cmap_values.py
https://github.com/fastplotlib/fastplotlib/blob/master/examples/desktop/line_collection/line_collection_cmap_values_qualitative.py


          fix cmap_values were not set in the @Setter D=

8349b00

kushalkolar merged commit 2902220 into master

kushalkolar deleted the fix-line-collection-cmap-values-setter branch

October 19, 2023 03:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet