Content-Length: 268702 | pFad | https://github.com/fastplotlib/fastplotlib/pull/433

BC A bit of black by almarklein · Pull Request #433 · fastplotlib/fastplotlib · GitHub
Skip to content

A bit of black #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2024
Merged

A bit of black #433

merged 2 commits into from
Mar 14, 2024

Conversation

almarklein
Copy link
Collaborator

@almarklein almarklein commented Mar 13, 2024 •
edited
Loading

  • The script that generates graphic_methods_mixin.py now also blackens the code. (could take this nearly verbatim from the wgpu codegen)
  • Blackend a few more files.

Now only the examples are unblacked. I can add that too if you want, but I was not sure if certain PR's may be affected.

@almarklein
Copy link
Collaborator Author

I think it makes sense to move the generate_x scripts out of the fastplotlib dir into a special scripts dir in the root of the repo, since they're not part of the library. But generate_colormaps.py is touched in #390, so I left it in place.

@kushalkolar
Copy link
Member

I think it makes sense to move the generate_x scripts out of the fastplotlib dir into a special scripts dir in the root of the repo, since they're not part of the library.

Makes sense!

But generate_colormaps.py is touched in #390, so I left it in place.

Yup I need to get back to that PR, probably next week. But generate_colormaps.py will disappear after we incorporate Talley's cmap lib

@almarklein almarklein marked this pull request as ready for review March 14, 2024 08:15
@kushalkolar kushalkolar merged commit 8ebbe5c into main Mar 14, 2024
@kushalkolar kushalkolar deleted the gen_methods branch March 20, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@almarklein @kushalkolar








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/fastplotlib/fastplotlib/pull/433

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy