Content-Length: 5449 | pFad | https://github.com/fastplotlib/fastplotlib/pull/436.patch

thub.com From ae72be988b6f11065ca0c7946dcf9e9c508189c7 Mon Sep 17 00:00:00 2001 From: EricThomson Date: Sun, 17 Mar 2024 20:29:23 -0400 Subject: [PATCH 1/8] ignore vscode config dir --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 9857fe4b2..c599d5f8c 100644 --- a/.gitignore +++ b/.gitignore @@ -131,4 +131,7 @@ dmypy.json # Pycharm .idea/ +# vs code +.vscode/ + examples/desktop/diffs/*.png From c60f247c27fc863e448dc9dfc187b1c92a137341 Mon Sep 17 00:00:00 2001 From: EricThomson Date: Sun, 17 Mar 2024 23:59:42 -0400 Subject: [PATCH 2/8] added black to optional tests install --- setup.py | 1 + 1 file changed, 1 insertion(+) diff --git a/setup.py b/setup.py index 2622b1406..a06a879a5 100644 --- a/setup.py +++ b/setup.py @@ -31,6 +31,7 @@ "tests": [ "pytest<8.0.0", "nbmake", + "black", "scipy", "imageio[pyav]", "jupyterlab", From 3c8f0cd23179bfd2a05bd7643115373c17b01676 Mon Sep 17 00:00:00 2001 From: EricThomson Date: Mon, 18 Mar 2024 13:27:52 -0400 Subject: [PATCH 3/8] added black linting to ci --- .github/workflows/ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fddfae5f4..db119ac2f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,6 +14,9 @@ on: - ready_for_review jobs: + black-check: + - name: Black Code Formatter + - uses: lgeiger/black-action@v1.0.1 docs-build: name: Docs From 8029fa2ebd410ef111c2457aee7e49e3ad8130c6 Mon Sep 17 00:00:00 2001 From: EricThomson Date: Mon, 18 Mar 2024 15:05:50 -0400 Subject: [PATCH 4/8] fix syntax in black linter ci.yml --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index db119ac2f..5931d3d85 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,7 +15,8 @@ on: jobs: black-check: - - name: Black Code Formatter + name: black + steps: - uses: lgeiger/black-action@v1.0.1 docs-build: From 62dc1853722d20c7a2ec451bd567c4411353f9fc Mon Sep 17 00:00:00 2001 From: EricThomson Date: Tue, 19 Mar 2024 09:08:40 -0400 Subject: [PATCH 5/8] add black.yml to workflows --- .github/workflows/black.yml | 10 ++++++++++ .github/workflows/ci.yml | 5 ----- 2 files changed, 10 insertions(+), 5 deletions(-) create mode 100644 .github/workflows/black.yml diff --git a/.github/workflows/black.yml b/.github/workflows/black.yml new file mode 100644 index 000000000..0a8b8e925 --- /dev/null +++ b/.github/workflows/black.yml @@ -0,0 +1,10 @@ +name: Lint + +on: [push, pull_request] + +jobs: + lint: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - uses: psf/black@stable \ No newline at end of file diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5931d3d85..40d39c4f6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,11 +14,6 @@ on: - ready_for_review jobs: - black-check: - name: black - steps: - - uses: lgeiger/black-action@v1.0.1 - docs-build: name: Docs runs-on: bigmem From 400fcbde847edb637990199639e58112fdcc1be9 Mon Sep 17 00:00:00 2001 From: EricThomson Date: Tue, 19 Mar 2024 09:17:07 -0400 Subject: [PATCH 6/8] transition from node16 to node20 --- .github/workflows/black.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/black.yml b/.github/workflows/black.yml index 0a8b8e925..b2cd244f7 100644 --- a/.github/workflows/black.yml +++ b/.github/workflows/black.yml @@ -6,5 +6,5 @@ jobs: lint: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: psf/black@stable \ No newline at end of file From 0521842f7b5a70b36a225638745fb910370ad3de Mon Sep 17 00:00:00 2001 From: EricThomson Date: Tue, 19 Mar 2024 09:26:43 -0400 Subject: [PATCH 7/8] add jupyter to black workflow --- .github/workflows/black.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/black.yml b/.github/workflows/black.yml index b2cd244f7..d647c9554 100644 --- a/.github/workflows/black.yml +++ b/.github/workflows/black.yml @@ -7,4 +7,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: psf/black@stable \ No newline at end of file + - uses: psf/black@stable + with: + jupyter: true \ No newline at end of file From ea4292a1e40fc4358ab3f40d050b83cd47999ab6 Mon Sep 17 00:00:00 2001 From: EricThomson Date: Tue, 19 Mar 2024 22:30:38 -0400 Subject: [PATCH 8/8] direct linter to source --- .github/workflows/black.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/black.yml b/.github/workflows/black.yml index d647c9554..bcb2d2b33 100644 --- a/.github/workflows/black.yml +++ b/.github/workflows/black.yml @@ -9,4 +9,4 @@ jobs: - uses: actions/checkout@v4 - uses: psf/black@stable with: - jupyter: true \ No newline at end of file + src: "./fastplotlib" \ No newline at end of file

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!