Content-Length: 287418 | pFad | https://github.com/fastplotlib/fastplotlib/pull/784

64 Use _version.py that includes details using git by almarklein · Pull Request #784 · fastplotlib/fastplotlib · GitHub
Skip to content

Use _version.py that includes details using git #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Conversation

almarklein
Copy link
Collaborator

Using the same module as pygfx and wgpu, which includes more detailed version info when you're inside a git repo.

Copy link

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/versioning

@kushalkolar
Copy link
Member

So with this when it's a git version number, it's interpreated as version x.y.z + git-commit? So from now on bump right before release? I would usually bump after a release.

@kushalkolar kushalkolar merged commit 8ef6581 into main Apr 1, 2025
52 checks passed
@almarklein
Copy link
Collaborator Author

So with this when it's a git version number, it's interpreated as version x.y.z + git-commit?

Yes, e.g. my current pygfx is 0.7.0.post56+g092bc843.dirty, which is 56 commits after the last git vx.y.z tag, the git commit hash is also present. And the .dirty means that I have uncommitted changes :)

So from now on bump right before release? I would usually bump after a release.

Ah, so I guess that in your previous system the main is a bit like a preview (wip) of the upcoming release.

An advantage of bumping right before a release is that you can pick what number to bump, which usually depends a bit on how much (the API) has changed since the previous release.

I don't want to force either system on you. Actually, you could still bump after a release, and we could change the post to pre 🤷

@kushalkolar
Copy link
Member

Ah, so I guess that in your previous system the main is a bit like a preview (wip) of the upcoming release.

yup, let's just follow the same system for fpl after the next release, easier for everyone!

@kushalkolar kushalkolar deleted the versioning branch April 18, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/fastplotlib/fastplotlib/pull/784

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy