Content-Length: 247667 | pFad | https://github.com/fleaflet/flutter_map/pull/2025

A0 fix: invoke map interaction callbacks with coordinates in primary world by monsieurtanuki · Pull Request #2025 · fleaflet/flutter_map · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invoke map interaction callbacks with coordinates in primary world #2025

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

monsieurtanuki
Copy link
Contributor

What

Impacted files

  • camera.dart: now looking for the best world before unprojecting a pixel
  • multi_worlds.dart: added an onTap event to create on the fly markers

Adding markers around New Zealand and longitude 180

Screenshot_1738239927

Adding markers in a multi-world

Screenshot_1738236612

Impacted files:
* `camera.dart`: now looking for the best world before unprojecting a pixel
* `multi_worlds.dart`: added an `onTap` event to create on the fly markers
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JaffaKetchup JaffaKetchup changed the title fix: multi-world onTap fix: ensure onTap coordinates callback argument is in primary world Jan 30, 2025
@JaffaKetchup JaffaKetchup changed the title fix: ensure onTap coordinates callback argument is in primary world fix: invoke map interaction callbacks with coordinates in primary world Jan 30, 2025
@JaffaKetchup JaffaKetchup merged commit d197dba into fleaflet:master Jan 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Map callbacks with coordinate arguments do not work correctly when invoked on 'non-primary' world
2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/fleaflet/flutter_map/pull/2025

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy