Content-Length: 267331 | pFad | https://github.com/flutter/flutter/issues/105152

5D Create flag for turning off the dart profiler · Issue #105152 · flutter/flutter · GitHub
Skip to content

Create flag for turning off the dart profiler #105152

@gaaclarke

Description

@gaaclarke

In dart-lang/sdk#49119 it was found that the dart profiler can aggravate the paging in of code in the VM which can cause the wall time spent in symbols to inflate to 2x. For profile builds this can skew benchmarks that rely on wall time. We should add a flag to flutter tool that allows us to launch the process without the dart profiler running.

In practice I think benchmarks usually repeat tests, like //dev/benchmarks/microbenchmarks/lib/stocks/build_bench.dart, so that the increased cost of the first run would get averaged out. I'm not sure there is a need for this flag beyond manually profiling apps. It's particularly acute when using DevTools and looking at the Timeline events since the CPU time for symbols isn't visible there.

Related issue: #104656

cc @kenzieschmoll @dnfield

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.triaged-toolTriaged by Flutter Tool team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions









      ApplySandwichStrip

      pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


      --- a PPN by Garber Painting Akron. With Image Size Reduction included!

      Fetched URL: https://github.com/flutter/flutter/issues/105152

      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy