-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Open
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.c: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.team-toolOwned by Flutter Tool teamOwned by Flutter Tool teamteam: skip-testAn issue used to track tests that are skipped.An issue used to track tests that are skipped.toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.Issues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.triaged-toolTriaged by Flutter Tool teamTriaged by Flutter Tool team
Description
As part of the skip test audit: #86396, the follow test is skipped:
flutter/packages/flutter_tools/test/integration.shard/variable_expansion_windows_test.dart
Lines 12 to 20 in 6876c52
// Regression test for https://github.com/flutter/flutter/issues/84270 . | |
testWithoutContext('dart command will expand variables on windows', () async { | |
final ProcessResult result = await processManager.run(<String>[ | |
fileSystem.path.join(getFlutterRoot(), 'bin', 'dart'), | |
fileSystem.path.join(getFlutterRoot(), 'packages', 'flutter_tools', 'test', 'integration.shard', 'variable_expansion_windows.dart'), | |
'"^(?!Golden).+"', | |
]); | |
expect(result.stdout, contains('args: ["(?!Golden).+"]')); | |
}, skip: 'Reverted in https://github.com/flutter/flutter/pull/86000'); |
If it is reenabled it will fail with:
04:11 +31 -1: test\integration.shard\variable_expansion_windows_test.dart: dart command will expand variables on windows [E]
Expected: contains 'args: ["(?!Golden).+"]'
Actual: 'args: ["(?Golden).+"]\r\n'
''
package:test_api expect
test\integration.shard\variable_expansion_windows_test.dart 19:5 main.<fn>
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.c: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.team-toolOwned by Flutter Tool teamOwned by Flutter Tool teamteam: skip-testAn issue used to track tests that are skipped.An issue used to track tests that are skipped.toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.Issues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.triaged-toolTriaged by Flutter Tool teamTriaged by Flutter Tool team