Content-Length: 298267 | pFad | https://github.com/flutter/flutter/issues/89044

0B [Web][Desktop] feature req: flutter_driver custom scroll Command for web and desktop. · Issue #89044 · flutter/flutter · GitHub
Skip to content

[Web][Desktop] feature req: flutter_driver custom scroll Command for web and desktop. #89044

@laurensdewaele

Description

@laurensdewaele

Use case

FlutterDriver's scroll fires a Scroll command that triggers the _scroll method on the handler_factory that first performs a pointer.down, pointer.move and then a pointer.up. This indeed makes a lot of sense for mobile.

However, now that Flutter is also targeting desktop and web, it would be nice to have a 'normal' non-mobile scroll implemented in the FlutterDriver as a standard.

Proposal

Seeing as scrolling is the same for desktop and web, I suggest renaming the current (mobile) Scroll Command to MobileScroll. Thus also renaming the method name on the factory_handler.dart from _scroll to _mobileScroll.

Create a new Scroll Command and implement a _scroll method on the factory_handler.dart to perform a pointer.scroll without the pointer.down and pointer.up.

I am still a bit torn on renaming the actual scroll method on FlutterDriver, as that is breaking.
We could just apply a scroll method on WebFlutterDriver, but this ignores desktop.

Thoughts?

I would be happy to do the PR for this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projecta: desktopRunning on desktopc: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterplatform-webWeb applications specificallyt: flutter driver"flutter driver", flutter_drive, or a driver testteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.triaged-toolTriaged by Flutter Tool team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions









      ApplySandwichStrip

      pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


      --- a PPN by Garber Painting Akron. With Image Size Reduction included!

      Fetched URL: https://github.com/flutter/flutter/issues/89044

      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy