fix: Ensure Plans::DestroyJob are queued only once #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is meant to avoid issues when a user tries to delete a plan more than once. This happens because the plan deletion is performed as a background job and could take some time as all child plans must be deleted, subscriptions terminated, invoices generated and discarded, etc...
lovrocolic
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is meant to avoid issues when a user tries to delete a plan more than once. This happens because the plan deletion is performed as a background job and could take some time as all child plans must be deleted, subscriptions terminated, invoices generated and discarded, etc...
The goal of this change is to avoid failed jobs because of race conditions between multiple runs for the same plan producing unique DB index constraints errors or discard! errors as those only produce noise and waste of support time.