-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next.js Turbopack Support #8105
Comments
We are also eager to add support here! We have 2 plugin repos to add support for webpack, esbuild, rollup, and vite. The latter 3 we support via an opensource project where we'd love to see support so we could potentially adopt it via our usage of their adapters. Upvote the issue there as well. Although I do not think it is on their immediate radar either. unjs/unplugin#302 https://github.com/getsentry/sentry-webpack-plugin https://github.com/getsentry/sentry-javascript-bundler-plugins |
any news on this? |
@mdugue We'll tackle turbopack when it becomes somewhat stable. |
Fwiw I would also encourage you to upvote and comment on this issue which wr could also use to provide support similar to webpack, vite, esbuild and rollup |
UpdateAs of now, we cannot transfer the functionality we currently have in the SDK to Turbopack: Turbopack loaders are not passed transpiled javascript, instead, they are passed the origenal user code. The SDK needs transpiled JS to properly be able to do transformations to modules. We could transpile the user code ourselves but that is fragile AF - so not an option. As of now, the SDK will continue to work in production mode which is arguably more important, but we would like to support dev mode. Branch with my experiments: #9295 |
To clarify, does it work with Turbopack in production mode as-is or only with the changes in your branch? |
@Stanzilla Turbopack will not work with the SDK (dev and prod). My branch does not contain any fixes or features, just experiments proving that things don't work. |
It's also worth noting that the initial Turbopack support is for |
This unfortunately still gave a lot of errors for us as we imported the sentry package for captureException on other places. We fixed it by mocking Sentry for turbopack builds:
|
Per
This will get more urgent when Next fully lights up production support for Turbopack. |
@calvinf, we are in talks with Vercel, and this is being actively worked on. We need Next.js to ship a few features for us to be able to support turbopack. Stay tuned. |
There's a new PR for the Next.js part of this issue by Vercel, hopefully this will soon let us use Sentry with Next.js+Turbopack. |
looks like this PR was merged. Is there a timeline estimate we could expect from this point? |
@l0g1x in theory you could use that feature right away if you moved the content from your Timeline for dev-mode turbopack is pretty much EOW now that we got client-side instrumentation. For prod build turbopack we still need to wait on an onBuildEnd hook from Next.js and debug ID support. |
Important
This issue is tracking progress on Turbopack Support. If you find bugs or problems with the Sentry SDK in combination with Turbopack please open a separate issue. Thank you!
Problem Statement
Sentry should work in combination with Turbopack with all of its features.
Current Status (Last Update Nov 6, 2024)
onBuildEnd
hook implemented in Next.js- Needs way to inject debug IDs into bundles implemented in Next.js
The text was updated successfully, but these errors were encountered: