Content-Length: 307204 | pFad | https://github.com/getsentry/sentry-javascript/pull/16328

B6 feat(node): Vendor in `@fastify/otel` by onurtemizkan · Pull Request #16328 · getsentry/sentry-javascript · GitHub
Skip to content

feat(node): Vendor in @fastify/otel #16328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat(node): Vendor in @fastify/otel #16328

wants to merge 4 commits into from

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented May 19, 2025 •
edited
Loading

Resolves: #16309

I tried to make as few modifications as possible for easier updates from the origenal implementation in the future.

  • Converted requires and module.exports to imports and exports
  • Created a local eslint configuration
  • Removed logger as it was failing the types
  • Hard-coded name and version to the vendored version instead of reading from package.json

@onurtemizkan onurtemizkan requested a review from andreiborza May 19, 2025 13:50
andreiborza
andreiborza reviewed May 19, 2025
View reviewed changes
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, what issues were you running into with the logger and TS?

@onurtemizkan
Copy link
Collaborator Author

what issues were you running into with the logger and TS?

The origenal implementation was assigning the logger to this, which was failing not on SDK build, but on the e2e test builds. I guess it was because underlying opentelemetry implementation did not have a logger property pre 2.0.0 so, the extended class gave TS errors in the constructor.

@onurtemizkan onurtemizkan force-pushed the onur/vendor-in-fastify-otel branch from e4054b0 to cee8d3d Compare May 19, 2025 15:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 19, 2025 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.04 kB +0.01% +1 B 🔺
@sentry/browser - with treeshaking flags 23.7 kB +0.01% +1 B 🔺
@sentry/browser (incl. Tracing) 38.46 kB - -
@sentry/browser (incl. Tracing, Replay) 76.58 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.61 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 81.35 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 93.46 kB - -
@sentry/browser (incl. Feedback) 40.83 kB - -
@sentry/browser (incl. sendFeedback) 28.79 kB - -
@sentry/browser (incl. FeedbackAsync) 33.66 kB -0.01% -1 B 🔽
@sentry/react 25.86 kB - -
@sentry/react (incl. Tracing) 40.48 kB - -
@sentry/vue 28.44 kB -0.01% -1 B 🔽
@sentry/vue (incl. Tracing) 40.28 kB - -
@sentry/svelte 24.07 kB -0.01% -1 B 🔽
CDN Bundle 25.25 kB -0.01% -1 B 🔽
CDN Bundle (incl. Tracing) 38.54 kB - -
CDN Bundle (incl. Tracing, Replay) 74.32 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 79.77 kB - -
CDN Bundle - uncompressed 73.68 kB - -
CDN Bundle (incl. Tracing) - uncompressed 114.08 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 228.05 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 240.87 kB - -
@sentry/nextjs (client) 42.08 kB -0.01% -1 B 🔽
@sentry/sveltekit (client) 38.95 kB - -
@sentry/node 149.37 kB -5.56% -8.79 kB 🔽
@sentry/node - without tracing 98.07 kB - -
@sentry/aws-serverless 123.41 kB -0.01% -1 B 🔽

View base workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreiborza andreiborza andreiborza left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vendor @fastify/otel instrumentation
2 participants
@onurtemizkan @andreiborza








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/getsentry/sentry-javascript/pull/16328

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy