Content-Length: 450647 | pFad | https://github.com/getsentry/sentry-react-native/pull/4561

68 chore(samples): Add package scripts for native builds, dsn and testing by krystofwoldrich · Pull Request #4561 · getsentry/sentry-react-native · GitHub
Skip to content

chore(samples): Add package scripts for native builds, dsn and testing #4561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 21, 2025
Merged

chore(samples): Add package scripts for native builds, dsn and testing #4561

merged 10 commits into from
Feb 21, 2025

Conversation

krystofwoldrich
Copy link
Member

This PR adds package scripts for the matrix of builds we support with our sample app, which makes it simpler to build and test different versions of the app.

Example usage:

yarn pod-install-debug-static

yarn set-test-dsn-ios
yarn build-ios-debug
yarn test-ios

yarn set-test-dsn-android
yarn build-android-debug
yarn test-android

#skip-changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 343.90 ms 357.45 ms 13.55 ms
Size 17.75 MiB 20.11 MiB 2.36 MiB

Baseline results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
1a89392 412.59 ms 424.69 ms 12.10 ms
18a5066 427.89 ms 436.47 ms 8.57 ms
b6d933c 442.52 ms 461.82 ms 19.30 ms
208f4af 439.23 ms 427.31 ms -11.92 ms
5625ce7 476.74 ms 488.24 ms 11.50 ms
b75148e 440.04 ms 421.36 ms -18.68 ms
555070f 438.67 ms 428.30 ms -10.37 ms
454f971 436.27 ms 478.76 ms 42.48 ms

App size

Revision Plain With Sentry Diff
1a89392 17.75 MiB 20.11 MiB 2.37 MiB
18a5066 17.75 MiB 20.11 MiB 2.37 MiB
b6d933c 17.75 MiB 20.11 MiB 2.37 MiB
208f4af 17.75 MiB 20.11 MiB 2.37 MiB
5625ce7 17.75 MiB 20.11 MiB 2.37 MiB
b75148e 17.75 MiB 20.11 MiB 2.37 MiB
555070f 17.75 MiB 20.11 MiB 2.37 MiB
454f971 17.75 MiB 20.11 MiB 2.37 MiB

Previous results on branch: kw-simplify-local-sample-testing

Startup times

Revision Plain With Sentry Diff
29e6f61 464.30 ms 487.35 ms 23.04 ms
7430ff6 408.00 ms 453.50 ms 45.50 ms
937f6e2 355.20 ms 377.10 ms 21.90 ms

App size

Revision Plain With Sentry Diff
29e6f61 17.75 MiB 20.11 MiB 2.37 MiB
7430ff6 17.75 MiB 20.11 MiB 2.37 MiB
937f6e2 17.75 MiB 20.11 MiB 2.37 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 426.66 ms 464.02 ms 37.36 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Baseline results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
5625ce7+dirty 358.15 ms 416.65 ms 58.50 ms
b6d933c+dirty 398.43 ms 456.62 ms 58.19 ms
8d0daf6+dirty 393.58 ms 394.84 ms 1.26 ms
18a5066+dirty 370.06 ms 414.10 ms 44.04 ms
1a89392+dirty 425.56 ms 530.65 ms 105.09 ms
b75148e+dirty 428.91 ms 461.26 ms 32.35 ms
454f971+dirty 439.04 ms 423.88 ms -15.16 ms
208f4af+dirty 346.93 ms 402.77 ms 55.84 ms
555070f+dirty 388.25 ms 424.44 ms 36.19 ms

App size

Revision Plain With Sentry Diff
5625ce7+dirty 7.15 MiB 8.38 MiB 1.23 MiB
b6d933c+dirty 7.15 MiB 8.38 MiB 1.23 MiB
8d0daf6+dirty 7.15 MiB 8.38 MiB 1.23 MiB
18a5066+dirty 7.15 MiB 8.38 MiB 1.23 MiB
1a89392+dirty 7.15 MiB 8.38 MiB 1.23 MiB
b75148e+dirty 7.15 MiB 8.38 MiB 1.23 MiB
454f971+dirty 7.15 MiB 8.38 MiB 1.23 MiB
208f4af+dirty 7.15 MiB 8.38 MiB 1.23 MiB
555070f+dirty 7.15 MiB 8.38 MiB 1.23 MiB

Previous results on branch: kw-simplify-local-sample-testing

Startup times

Revision Plain With Sentry Diff
29e6f61+dirty 394.80 ms 386.78 ms -8.02 ms
937f6e2+dirty 397.14 ms 420.40 ms 23.26 ms
7430ff6+dirty 351.51 ms 353.67 ms 2.16 ms

App size

Revision Plain With Sentry Diff
29e6f61+dirty 7.15 MiB 8.38 MiB 1.23 MiB
937f6e2+dirty 7.15 MiB 8.38 MiB 1.23 MiB
7430ff6+dirty 7.15 MiB 8.38 MiB 1.23 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1229.94 ms 1232.40 ms 2.46 ms
Size 2.63 MiB 3.74 MiB 1.11 MiB

Baseline results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
555070f+dirty 1213.59 ms 1217.79 ms 4.20 ms
b6d933c+dirty 1217.71 ms 1220.58 ms 2.87 ms
b75148e+dirty 1221.53 ms 1220.85 ms -0.68 ms
454f971+dirty 1220.55 ms 1225.82 ms 5.27 ms
8d0daf6+dirty 1230.90 ms 1233.16 ms 2.27 ms
208f4af+dirty 1209.44 ms 1217.13 ms 7.70 ms
18a5066+dirty 1218.00 ms 1212.27 ms -5.73 ms
5625ce7+dirty 1226.98 ms 1217.77 ms -9.21 ms
1a89392+dirty 1220.12 ms 1216.69 ms -3.43 ms

App size

Revision Plain With Sentry Diff
555070f+dirty 2.63 MiB 3.69 MiB 1.05 MiB
b6d933c+dirty 2.63 MiB 3.70 MiB 1.06 MiB
b75148e+dirty 2.63 MiB 3.69 MiB 1.06 MiB
454f971+dirty 2.63 MiB 3.74 MiB 1.11 MiB
8d0daf6+dirty 2.63 MiB 3.74 MiB 1.11 MiB
208f4af+dirty 2.63 MiB 3.69 MiB 1.05 MiB
18a5066+dirty 2.63 MiB 3.70 MiB 1.06 MiB
5625ce7+dirty 2.63 MiB 3.70 MiB 1.06 MiB
1a89392+dirty 2.63 MiB 3.70 MiB 1.06 MiB

Previous results on branch: kw-simplify-local-sample-testing

Startup times

Revision Plain With Sentry Diff
29e6f61+dirty 1216.02 ms 1228.84 ms 12.82 ms
937f6e2+dirty 1221.29 ms 1222.53 ms 1.24 ms
7430ff6+dirty 1228.63 ms 1240.98 ms 12.35 ms

App size

Revision Plain With Sentry Diff
29e6f61+dirty 2.63 MiB 3.74 MiB 1.11 MiB
937f6e2+dirty 2.63 MiB 3.74 MiB 1.11 MiB
7430ff6+dirty 2.63 MiB 3.74 MiB 1.11 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1208.11 ms 1219.86 ms 11.75 ms
Size 3.19 MiB 4.30 MiB 1.12 MiB

Baseline results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
555070f+dirty 1223.61 ms 1227.57 ms 3.96 ms
b6d933c+dirty 1228.02 ms 1235.32 ms 7.30 ms
b75148e+dirty 1202.72 ms 1212.04 ms 9.32 ms
454f971+dirty 1233.51 ms 1239.18 ms 5.67 ms
8d0daf6+dirty 1227.80 ms 1236.83 ms 9.03 ms
208f4af+dirty 1213.08 ms 1223.82 ms 10.73 ms
18a5066+dirty 1244.20 ms 1251.54 ms 7.34 ms
5625ce7+dirty 1219.73 ms 1223.80 ms 4.07 ms
1a89392+dirty 1229.00 ms 1234.78 ms 5.78 ms

App size

Revision Plain With Sentry Diff
555070f+dirty 3.19 MiB 4.25 MiB 1.06 MiB
b6d933c+dirty 3.19 MiB 4.26 MiB 1.08 MiB
b75148e+dirty 3.19 MiB 4.25 MiB 1.07 MiB
454f971+dirty 3.19 MiB 4.31 MiB 1.12 MiB
8d0daf6+dirty 3.19 MiB 4.30 MiB 1.12 MiB
208f4af+dirty 3.19 MiB 4.25 MiB 1.06 MiB
18a5066+dirty 3.19 MiB 4.26 MiB 1.08 MiB
5625ce7+dirty 3.19 MiB 4.26 MiB 1.08 MiB
1a89392+dirty 3.19 MiB 4.26 MiB 1.08 MiB

Previous results on branch: kw-simplify-local-sample-testing

Startup times

Revision Plain With Sentry Diff
29e6f61+dirty 1229.31 ms 1235.08 ms 5.78 ms
937f6e2+dirty 1227.73 ms 1218.65 ms -9.08 ms
7430ff6+dirty 1223.08 ms 1219.17 ms -3.91 ms

App size

Revision Plain With Sentry Diff
29e6f61+dirty 3.19 MiB 4.31 MiB 1.12 MiB
937f6e2+dirty 3.19 MiB 4.31 MiB 1.12 MiB
7430ff6+dirty 3.19 MiB 4.31 MiB 1.12 MiB

antonis
antonis reviewed Feb 19, 2025
View reviewed changes
antonis
antonis reviewed Feb 19, 2025
View reviewed changes
@krystofwoldrich krystofwoldrich changed the base branch from capture-app-start-errors to kw-fix-bad-merge February 19, 2025 10:11
Base automatically changed from kw-fix-bad-merge to capture-app-start-errors February 20, 2025 09:04
antonis
antonis reviewed Feb 20, 2025
View reviewed changes
@antonis
Copy link
Collaborator

antonis commented Feb 20, 2025 •
edited
Loading

Thank you for this enhancement @krystofwoldrich 🙇

The PR looks great and the scripts worked as expected in my tests. I left a nitpick pick but feel free to ignore since I might be the only one using those scripts 😅
We could also update the contributor's guide sample section with the changes and the new scripts.

I think the Test ios production failure is due to the way the downloaded archive is unzipped. The sentry-react-native-sample.app.zip seems to be unzipped to a folder. Probably just copying to sentry-react-native-sample.app with ditto could work 🤞

antonis
antonis approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Thank you for this enhancement Krystof 🙇

@krystofwoldrich krystofwoldrich merged commit e935360 into capture-app-start-errors Feb 21, 2025
68 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-simplify-local-sample-testing branch February 21, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @antonis








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/getsentry/sentry-react-native/pull/4561

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy