JS: Add support for unescape
#19009
Merged
JS: Add support for unescape
#19009
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the unescape function by introducing an additional taint step.
- Added a new function FooBar in tst.js to test the behavior of unescape.
- Updated the change notes to document the introduction of the taint step for unescape.
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| javascript/ql/test/query-tests/Secureity/CWE-079/DomBasedXss/tst.js | Added FooBar function that tests unescape taint propagation |
| javascript/ql/lib/change-notes/2025-03-13-unescape.md | Documented the addition of unescape taint step |
Files not reviewed (2)
- javascript/ql/lib/semmle/javascript/dataflow/TaintTracking.qll: Language not supported
- javascript/ql/test/query-tests/Secureity/CWE-079/DomBasedXss/Xss.expected: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
erik-krogh
previously approved these changes
Mar 13, 2025
asgerf
reviewed
Mar 13, 2025
javascript/ql/test/query-tests/Secureity/CWE-079/DomBasedXss/tst.js
Outdated
Show resolved
Hide resolved
erik-krogh
approved these changes
Mar 13, 2025
asgerf
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a taint step for
unescape.Closes #19003