-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GHES #12
Comments
@cschleiden any ETA or status on when this could be possible? |
@thedaviddias No updates to share at this point, we are still figuring out the next set of priorities. |
Thank you @cschleiden! |
I'm about to on-board 300+ developers to GHES and would love to tell them "you can use this extension to mind your Actions activities directly in VSCode." |
I'm member of a 20000+ user GHES instance and would also love to see some prioritization of this ticket. |
This would also require a tiny change to the language server, which I proposed in actions/languageservices#43, to actually show all the relevant information |
I implemented the necessary changes in #183, would be happy if someone could review 😄 |
x-posting my comment here:
|
Any update on this? I can see the README now mentions it but it looks like that was a preemptive change. We have a large number of internal developers excited to use this extension with our 3.8 GHES instance. |
In our work environment we use GHES 3.8 and I was also able to connect, so it works... partially. There is currently an issue when retrieving organization secrets for a repository while hovering over my actions code (showing This is because GHES 3.8 doesn't support the most recent GitHub API yet and the List repository organization secrets endpoint is not available in 3.8. This will change with GHES 3.9:
Maybe this helps. |
1 similar comment
One note, after enabling GHES support, the actions that are sourced from our enterprise server are still linking to |
The same problem exists referencing reusable workflows. They reference github.com instead of our GHES instance. |
Could some kind of override be added for the known named actions? The easiest way around this might be to just deploy global vs code settings to our users with a list of internal actions. Maybe a wildcard for an org name to just assume it exists and link to it based on a setting? |
Not sure what this is meant to solve; repositories hosted on GHES cannot access any actions from github.com, so there is no need to sometimes look up actions on the cloud, sometimes on GHES. All actions, including built-ins like "checkout", have to be available on that GHES instance (the built-ins are bundled with the server setup, so their version can be significantly different than on github.com!). IMHO, the extension needs to determine the github instance the repository is hosted on, and stick with that for all workflows in that repo. And actually it should already know it, as it correctly lists workflows, opens logs on GHES, etc., so it knows where that workflow is hosted. It just needs to connect that knowledge to opening actions. |
It is the case that the GHES instance comes with an |
Thank you, I did not know about this, we use the actions-sync tool mentioned in that same doc. I'm now glad I added that disclaimer in my comment 😆 |
I've had to explain this limitation to multiple folks asking my team why they were seeing errors in VSCode in the past two weeks, so it feels like missing behavior to me :) |
The Github authentication plugin allows to connect to priate instances of github enterprise
Please add a configuration field to allow to use private github instances
Thanks!
The text was updated successfully, but these errors were encountered: