Content-Length: 279853 | pFad | https://github.com/google/flexbox-layout/pull/163

92 Fix the incorrect denominator in the folllowing case by thagikura · Pull Request #163 · google/flexbox-layout · GitHub
Skip to content

Fix the incorrect denominator in the folllowing case #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2016
Merged

Conversation

thagikura
Copy link
Contributor

@thagikura thagikura commented Dec 19, 2016

This PR fixes the incorrect alignment where:

  • justifyContent is set to either or space_between or space_around
  • Views whose visibitilies are gone are included in a flex line

Also use the number of item count, which the number of gone items are filtered
where appropriate.

Fixes #162

- justifyContent is set to either or space_between or space_around
- Views whose visibitilies are gone are included

Use the number of item count, which the number of gone items are filtered
where appropriate.

Fixes #162
@thagikura thagikura requested a review from yaraki December 19, 2016 06:48
@thagikura
Copy link
Contributor Author

@yaraki could you have a look?

Copy link
Collaborator

@yaraki yaraki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

denominator is calculated incorrect when JustifyContent is space_between/space_around
2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/google/flexbox-layout/pull/163

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy