Content-Length: 256791 | pFad | https://github.com/hanami/hanami/pull/1291

E6 Simplify testing setup by jodosha · Pull Request #1291 · hanami/hanami · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify testing setup #1291

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Simplify testing setup #1291

merged 1 commit into from
Feb 17, 2023

Conversation

jodosha
Copy link
Member

@jodosha jodosha commented Feb 17, 2023

Enhancement

Simplify testing setup for Hanami contributors.

  • Removes outdated testing code from the script/ directory
  • Removes outdated tests from the spec/integration directory
  • Renames the default Rake task from spec:unit to spec to reflect that it runs the entire test suite
  • Changed the description in GitHub Actions workflow Run unit tests -> Run the test suite.
  • Updated testing instructions into README.

Closes #1288
Closes #1290

@jodosha jodosha added this to the v2.0.4 milestone Feb 17, 2023
@jodosha jodosha requested a review from timriley February 17, 2023 09:23
@jodosha jodosha self-assigned this Feb 17, 2023
@jodosha jodosha requested a review from a team February 17, 2023 09:23
solnic
solnic approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! ❤️

@jodosha jodosha merged commit 741e591 into main Feb 17, 2023
@jodosha jodosha deleted the chore/simplify-testing-setup branch February 17, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solnic solnic solnic approved these changes

@timriley timriley Awaiting requested review from timriley

Assignees

@jodosha jodosha

Labels
enhancement
Projects
None yet
Milestone
v2.0.4
Development

Successfully merging this pull request may close these issues.

Integration tests run twice in CI How do I run all the tests?
2 participants
@jodosha @solnic








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/hanami/hanami/pull/1291

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy