cleanup: NewShowWithConfig -> NewShow
#13600
Merged
+11
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
pull-request-size
bot
added
the
size/S
TerryHowe
suggested changes
Jan 6, 2025
pkg/action/show.go
Outdated
|
|
||
| // NewShowWithConfig creates a new Show object with the given configuration. | ||
| func NewShowWithConfig(output ShowOutputFormat, cfg *Configuration) *Show { | ||
| func NewShow2(output ShowOutputFormat, cfg *Configuration) *Show { |
There was a problem hiding this comment.
Suggested change
| func NewShow2(output ShowOutputFormat, cfg *Configuration) *Show { | |
| func NewShow(output ShowOutputFormat, cfg *Configuration) *Show { |
mattfarina
requested changes
Jan 7, 2025
gjenkins8
force-pushed
the
cleanup_NewShowWithConfig
branch
from
708e83e to
8468de4
Compare
I missed a commit sorry (During the removal I renamed NewConfig -> NewConfig2 to find callers of that) |
mattfarina
approved these changes
Jan 14, 2025
|
@gjenkins8 please feel free to merge when you're ready. It's approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
NewShowWithConfigreplacedNewShow. RemoveNewShow, and renameNewShowWithConfigtoNewShow.Special notes for your reviewer:
If applicable:
docs neededlabel should be applied if so)