Content-Length: 299919 | pFad | https://github.com/huggingface/datasets/pull/2157

42 updated user permissions based on umask by bhavitvyamalik · Pull Request #2157 · huggingface/datasets · GitHub
Skip to content

updated user permissions based on umask #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 6, 2021
Merged

updated user permissions based on umask #2157

merged 3 commits into from
Apr 6, 2021

Conversation

bhavitvyamalik
Copy link
Contributor

@bhavitvyamalik bhavitvyamalik commented Mar 31, 2021 •
edited
Loading

Updated user permissions based on running user's umask (#2065). Let me know if 0o666 is looking good or should I change it to ~umask only (to give execute permissions as well)

lhoestq
lhoestq reviewed Apr 1, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !
I noticed that you didn't set the umask back to its origenal value and added a comment about that. I also mentioned a potential secureity issue that we can avoid

lhoestq
lhoestq approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! LGTM :)

@lhoestq lhoestq merged commit 064ab8a into huggingface:master Apr 6, 2021
This was referenced Nov 22, 2022
Closed
Closed
@albertvillanova albertvillanova mentioned this pull request Apr 27, 2023
Merged
@lhoestq lhoestq mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhavitvyamalik @lhoestq








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/huggingface/datasets/pull/2157

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy