This repository has been archived by the owner on Feb 8, 2022. It is now read-only.
nat/natpmp: initial commit #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Layher <mdlayher@gmail.com>
Signed-off-by: Matt Layher <mdlayher@gmail.com>
|
I forgot that t.Cleanup was added in 1.14:
I'll change the signature to my older pattern: c, done := testServer(t)
defer done() |
Signed-off-by: Matt Layher <mdlayher@gmail.com>
Signed-off-by: Matt Layher <mdlayher@gmail.com>
Signed-off-by: Matt Layher <mdlayher@gmail.com>
Signed-off-by: Matt Layher <mdlayher@gmail.com>
danderson
approved these changes
Jul 29, 2020
Signed-off-by: Matt Layher <mdlayher@gmail.com>
|
Looks like this is probably a reasonable place to checkpoint the work. I took a look at netcheck and am mulling over some API ideas, but I think I'll open an issue before writing more code to ensure it ends up being something workable. Will squash and merge! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much a WIP and all feedback is welcome. I read a bit of the RFC and implemented request/response serialization and backoff/retry as recommended, but there's probably more intelligent things we can do as well. I've left TODO comments for things I am either unsure of or intend to do.
For now I've only implemented the "get external IP" method, but will take a look at the actual mapping calls once the overall structure is solid.
/cc @danderson @bradfitz @crawshaw