reuse annotation from api #46202
Merged
reuse annotation from api #46202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
needs-rebase
hzxuzhonghu
force-pushed
the
api-annotation
branch
from
34af970 to
f2c0944
Compare
istio-testing
removed
the
needs-rebase
| @@ -101,7 +91,7 @@ type Controller struct { | |||
| // do not support writing. We only use it here for reading WorkloadEntry/WorkloadGroup. | |||
| store model.ConfigStoreController | |||
|
|
|||
| // Note: unregister is to update the workload entry status: like setting `DisconnectedAtAnnotation` | |||
| // Note: unregister is to update the workload entry status: like setting `annotation.IoIstioDisconnectedAt.Name` | |||
There was a problem hiding this comment.
nit: comment with actual annotation name is more readable
| // TODO use status or another proper API instead of annotations | ||
|
|
||
| // AutoRegistrationGroupAnnotation on a WorkloadEntry stores the associated WorkloadGroup. | ||
| AutoRegistrationGroupAnnotation = "istio.io/autoRegistrationGroup" |
There was a problem hiding this comment.
May be it is lot simpler to replace the name at this constant and use the constants every where?
There was a problem hiding this comment.
Yes, but just align with others
hzxuzhonghu
added
the
release-notes-none
howardjohn
approved these changes
Jul 27, 2023
|
/test integ-pilot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR: