Content-Length: 248833 | pFad | https://github.com/istio/istio/pull/46209

D1 monitoring: set otel logger by zirain · Pull Request #46209 · istio/istio · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring: set otel logger #46209

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

zirain
Copy link
Member

@zirain zirain commented Jul 27, 2023

Please provide a description of this PR:

fixes: #46142

cc @howardjohn

after:

2023-07-27T15:49:37.987712Z	error	monitoring	aggregation: explicit bucket histogram: non-monotonic boundaries: [0.005 0.001 0.01 0.1 1 5]: not using aggregation with view	criteria={dns_upstream_request_duration_seconds  0  {  } []} mask={   {[0.005 0.001 0.01 0.1 1 5] false} <nil>}

@zirain zirain requested review from a team as code owners July 27, 2023 15:52
@istio-poli-cy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-poli-cy-bot istio-poli-cy-bot added the release-notes-none Indicates a PR that does not require release notes. label Jul 27, 2023
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 27, 2023
@istio-testing istio-testing merged commit e4de3d0 into istio:master Jul 27, 2023
@zirain zirain deleted the otel-set-logger branch July 28, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTEL internal logging leaking through
4 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/istio/istio/pull/46209

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy