Content-Length: 248081 | pFad | https://github.com/jagenjo/litegraph.js/pull/155#issuecomment-656602861

A9 Added typings for slot shape and replaced built files by ilyabesk · Pull Request #155 · jagenjo/litegraph.js · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added typings for slot shape and replaced built files #155

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

ilyabesk
Copy link
Contributor

@jagenjo, would you like to have built files pushed on every change request?
Also, what kind of project/example graphs should I use to do smoke testing of lib stability?

@jagenjo jagenjo merged commit e64363d into jagenjo:master Jul 10, 2020
@jagenjo
Copy link
Owner

jagenjo commented Jul 10, 2020

mmm, good question, I usually have horrible merge conflicts when I upload the build version that take me too much time to solve, but I want to keep the build version in the repo, so I guess it would be better if only one of us does the built, which would be me.

Do you find any objections against it?

Also, for testing, it is hard as the pool of nodes is huge, and most actions are performed during the rendering. Do you have something in mind?

@ilyabesk ilyabesk deleted the typings_fix_and_build branch July 10, 2020 12:23
@ilyabesk
Copy link
Contributor Author

ilyabesk commented Jul 10, 2020

mmm, good question, I usually have horrible merge conflicts when I upload the build version that take me too much time to solve, but I want to keep the build version in the repo, so I guess it would be better if only one of us does the built, which would be me.

Do you find any objections against it?

It's completely ok with me.
Maybe there should be a wiki with guidelines for anyone who wants to collaborate. I'm sure, you have many thoughts about that.
I also think that GitHub's CI can help automate this, but I'm not sure.

Also, for testing, it is hard as the pool of nodes is huge, and most actions are performed during the rendering. Do you have something in mind?

Yeah, UI testing is hard. But at least core parts should be tested.
I will give it a try and share if will have any decent ideas.

@jagenjo
Copy link
Owner

jagenjo commented Jul 10, 2020

Perfect, keep me updated.

I will consider creating some guidelines in the wiki for future collaboratos, although you are the biggest contributor so you have better hints to give to newcomers than me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/jagenjo/litegraph.js/pull/155#issuecomment-656602861

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy