This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Selectmenu: Add classes option #8309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gabrielschulhof were you wanting a review of this |
gabrielschulhof
force-pushed
the
7731-selectmenu-classes-option
branch
2 times, most recently
from
cd1e657 to
e7f778d
Compare
|
@arschmitz I've made a few more changes and I could use a review although I'm fairly certain it's not ready to go yet, but it'll be good to have another set of eyes on it so I have a clear list of what remains to be done. TIA! |
| @@ -79,16 +94,24 @@ return $.widget( "mobile.selectmenu", $.mobile.selectmenu, { | |||
| } | |||
|
|
|||
| if ( event.type === "vclick" || | |||
| event.keyCode && ( event.keyCode === $.mobile.keyCode.ENTER || event.keyCode === $.mobile.keyCode.SPACE ) ) { | |||
| event.keyCode && | |||
| ( event.keyCode === $.mobile.keyCode.ENTER || | |||
There was a problem hiding this comment.
use $.ui.keyCode this is deprecated
|
Looking good done for now |
arschmitz
added
Action: PR needs modification
and removed
Action: PR needs reviewing
labels
added 18 commits
June 18, 2016 23:28
$.mobile.widget.backcompat must not be undefined even if $.mobileBackcompat is false, since other widgets unconditionally extend with $.mobile.widget.backcompat and if $.mobile.widget.backcompat is undefined, then they end up doing $.widget( ..., undefined ) which results in _create() being assigned $.noop.
gabrielschulhof
force-pushed
the
7731-selectmenu-classes-option
branch
from
15f9447 to
33a5648
Compare
|
@arschmitz we have a load order race condition in kitchensink which seems to reliably manifest itself with core 1.9.1 in this PR. Aside from that it should be golden. I'll try to look into it whenever I get a chance. |
|
@arschmitz nm, using a |
|
Yaaaay! Tests are now no worse than 1.5-dev! |
|
👍 |
|
Awesome! @gabrielschulhof landed this in 1.5-dev. |
arschmitz
pushed a commit
to arschmitz/jquery-mobile
that referenced
this pull request
Jul 4, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.