Core: guard against null & undefined values in required method #2053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkni
force-pushed
the
required-method-null-undef-val
branch
3 times, most recently
from
a8f6905 to
92faa3b
Compare
|
I don't think there is a way to test it without using the normalizer. But the normalizer will not return I will update the tests of the other PR and merge it and then update this one to use the normalizer. For now, I added a description to the commit describing the needs for this fix. |
|
Merged the other pr, we can add the tests here |
Arkni
force-pushed
the
required-method-null-undef-val
branch
2 times, most recently
from
c43f371 to
7b535ef
Compare
|
We are good to go. |
An input element will never have undefined or null as value but the normalizer may return null or undefined for an element. Also, jQuery (< 3.x) returns `null` for select element with the multiple attribute set if no options are selected. As a result, the required method should guard against that.
Arkni
force-pushed
the
required-method-null-undef-val
branch
from
7b535ef to
83bfd48
Compare
|
I'm going to merge this for now. |
|
Awesome that our normalizer layer also turned out to be a good value-mocking test utility 😸 Great job, thx |
|
Yes, and also I see (from Stackoverflow and here) that a lot of folks are using it and found it useful too. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #2049