Content-Length: 335732 | pFad | https://github.com/jquery-validation/jquery-validation/pull/2057

10 Build: Include minified version of additional methods in npm package by Arkni · Pull Request #2057 · jquery-validation/jquery-validation · GitHub
Skip to content

Build: Include minified version of additional methods in npm package #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2017

Conversation

Arkni
Copy link
Member

@Arkni Arkni commented Sep 3, 2017

No description provided.

@Arkni
Copy link
Member Author

Arkni commented Sep 3, 2017

@staabm

Should we also add the localization folder to tags? In other words, adding it to this list:

done([
"dist/additional-methods.js",
"dist/additional-methods.min.js",
"dist/jquery.validate.js",
"dist/jquery.validate.min.js"
]);

@staabm
Copy link
Member

staabm commented Sep 3, 2017

Since nobody requested localizations in the npm package I would leave them out for now.

Whats your opinion?

@Arkni
Copy link
Member Author

Arkni commented Sep 3, 2017

The localization folder is already distributed as part of the npm package, see

"files": [
"dist/localization/",

I'm talking about the dist folder committed to GitHub as part of the released tag. See the dist folder of the release 1.17.0 as an example.

@staabm
Copy link
Member

staabm commented Sep 4, 2017

oh I see. please add it then.

build/release.js Outdated
@@ -37,6 +37,7 @@ Release.define({
generateArtifacts: function( done ) {
Release.exec( "grunt release", "Grunt command failed" );
done([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for beeing late to the party:

please add a note like keeps this is of files in sync with package.json "files"-key

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@staabm staabm merged commit 539fa4d into jquery-validation:master Sep 4, 2017
@staabm
Copy link
Member

staabm commented Sep 4, 2017

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/jquery-validation/jquery-validation/pull/2057

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy