Core: Call to resetInternals removed in remote validation callback #2242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! I'll take a look at it as soon as possible! |
|
Is there anybody alive here? |
|
I'd be alive, but I cannot pull it! :-) |
|
It needs a test, otherwise we just go round in circles :) |
Can you do the test ? |
|
Mmmm I should set up a project on purpose, quite hard to find the time (I
moved company 2 years ago, that issue was spotted in a previous company
project, working with all different technologies now...)
*----------------------------------*
*The worst thing about listening to Iron Maiden for the first time is that
you cannot listen to Iron Maiden for the first time ever again.*
…On Tue, 17 Jan 2023 at 09:54, julien-tschappat ***@***.***> wrote:
@leonardospina <https://github.com/leonardospina>
It needs a test, otherwise we just go round in circles :)
Can you do the test ?
—
Reply to this email directly, view it on GitHub
<#2242 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACVVRA7OG6IQ56UEHQFWII3WSZT4DANCNFSM4GHF2KAA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@leonardospina |
|
@julien-tschappat should be done can you try and access |
|
@bytestream FYI : @leonardospina |
bytestream
approved these changes
Jan 24, 2023
|
Many thanks @julien-tschappat :) |
|
Thank you @leonardospina @julien-tschappat @bytestream. |
|
My pleasure. |
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The modification is related to the following issues, which although marked as closed don't seem to be properly fixed:
#12
#1669
#1375
From the user point of view the issue is that fields in a form which has at least one field with remote validation will be "unhighlighted" if the remotely validated field has a valid default value (remote validation is successful and any other invalid field is cleared out);
Validation error messages are still shown on the interface, but the invalid fields are shown as valid (the CSS class is reset)
Thanks,
Leonardo