Additional: vinUS validation fails on valid vin numbers #2460
Conversation
Compare by value and type (===) does not work for this algorithm, as both cd and cdv can be either types at the same time. By comparing by value only (==) cd and cdv can be either integer or string, as a string number will be converted to a number reqardless of type.
src/additional/vinUS.js
Outdated
| } | ||
| if ( cd === cdv ) { | ||
| // cd and cdv can be either integer string | ||
| if ( cd == cdv ) { |
There was a problem hiding this comment.
I think parseInt() should be used instead. For example, (parseInt("X") === parseInt("X")) === false. Any complaint against that?
| if ( cd == cdv ) { | |
| if ( parseInt(cd) === parseInt(cdv) ) { |
There was a problem hiding this comment.
No, that will not work, if string cd ="X" and string cdv="X" should = true.
line 50 could be 'if (+cd === +cdv')' the plus(+) on a string will evaluate it to an int, other wise it is a string.
In reality, the vin check digit in location 8 should be transliterated to a number not a string.
That way the check digit cd and check digit vin cdv will always be a number.
|
I've rewritten the for loop, and removed the nested loop, different commit on my branch. |
Test cases include default test with 17 one's, and additional US and Canada VIN
|
Code is better now, replaced nested for loop with an array index lookup. |
bytestream
changed the title
|
Thanks ❤️ |
Compare by value and type (===) does not work for this algorithm, as both cd and cdv can be either types at the same time. By comparing by value only (==) cd and cdv can be either integer or string, as a string number will be converted to a number reqardless of type.
Relates to BUG: #2459