Core: Add support for Web Components #2493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks OK to me.
Why? The way you've done it would be my preference over several settings. |
bytestream
changed the title
I was thinking because customElements are now listening to both event types: "focusin.validate focusout.validate keyup.validate" but also to "click.validate" instead of just either one of them. The only reliable way to "split" imo would be to make it configurable by the user (therefore the single vs multiple config entries dilemma). |
bytestream
approved these changes
Jun 28, 2024
This was referenced Jul 17, 2024
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for this pull request
Description
This PR tries to add validation support for custom elements (Web Components). See #2492 for a first technical analysis.
It's possible that the current implementation is not good enough. Especially the part where I added the customElements to both, the "focusin.validate focusout.validate keyup.validate" events and to the "click.validate" events. Maybe we would need to try to differ there or we should go with "more settings value" mentioned in #2492 approach?