Content-Length: 262054 | pFad | https://github.com/lodash/lodash/pull/4496

A7 Short circuit sortedIndexBy methods for empty arrays by megawac · Pull Request #4496 · lodash/lodash · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Short circuit sortedIndexBy methods for empty arrays #4496

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Short circuit sortedIndexBy methods for empty arrays #4496

merged 1 commit into from
Oct 3, 2019

Conversation

megawac
Copy link
Contributor

@megawac megawac commented Oct 3, 2019

I have a use case that involves building many smallish sorted arrays so I'm using sortedIndexBy as part of an insertion sort logic. As empty arrays are a common condition for me, I figured I should reach out and see if we could get them short circuited. Cheers.

@jsf-clabot
Copy link

jsf-clabot commented Oct 3, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@megawac megawac force-pushed the short-circuit-sorted-index branch from 8c65c32 to 9b659d8 Compare October 3, 2019 20:04
@jdalton
Copy link
Member

jdalton commented Oct 3, 2019

Thanks @megawac!

You may also want to open this against the 4.17.15-post tag so that it will get into the next minor/patch release.

@jdalton jdalton merged commit 23286d6 into lodash:master Oct 3, 2019
@megawac
Copy link
Contributor Author

megawac commented Oct 3, 2019

Sounds good

@megawac megawac deleted the short-circuit-sorted-index branch October 3, 2019 21:17
@megawac megawac mentioned this pull request Oct 3, 2019
Merged
@jdalton jdalton added issue bankruptcy Closing the issue/PR to start fresh and removed issue bankruptcy Closing the issue/PR to start fresh labels Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@megawac @jsf-clabot @jdalton








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/lodash/lodash/pull/4496

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy