Content-Length: 323666 | pFad | https://github.com/meilisearch/meilisearch/pull/4990

2C Add image source label to dockerfiles by wuast94 · Pull Request #4990 · meilisearch/meilisearch · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image source label to dockerfiles #4990

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

wuast94
Copy link
Contributor

@wuast94 wuast94 commented Oct 8, 2024

To get changelogs shown with Renovate a docker container has to add the source label described in the OCI Image Format Specification.

For reference: https://github.com/renovatebot/renovate/blob/main/lib/modules/datasource/docker/readme.md

@curquiza curquiza self-requested a review October 8, 2024 10:22
@curquiza
Copy link
Member

curquiza commented Oct 8, 2024

Hello @wuast94
Sorry, we are not interested in Renovate so far

I close this PR, but thanks for the suggestion 😊 We will re-open this PR if we change our mind

@curquiza curquiza closed this Oct 8, 2024
@wuast94
Copy link
Contributor Author

wuast94 commented Oct 8, 2024

@curquiza its not to add renovate here, its so that repos that run renovate like mine can show the release notes. i run renovate on my repo to make pull requests on new versions.

@curquiza
Copy link
Member

curquiza commented Oct 8, 2024

My baaaad, I just understood, I went too fast. Reopening and merging

@curquiza curquiza reopened this Oct 8, 2024
Dockerfile Outdated Show resolved Hide resolved
@curquiza curquiza added the enhancement New feature or improvement label Oct 8, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link
Contributor

meili-bors bot commented Oct 8, 2024

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@curquiza curquiza added this to the v1.12.0 milestone Oct 8, 2024
@curquiza
Copy link
Member

curquiza commented Oct 8, 2024

bors merge

Copy link
Contributor

meili-bors bot commented Oct 8, 2024

Stopped waiting for PR status (Github check) without running due to duplicate requests to run. You may check Bors to see that this PR is included in a batch by one of the other requests.

Copy link
Contributor

meili-bors bot commented Oct 8, 2024

@meili-bors meili-bors bot merged commit d907d1b into meilisearch:main Oct 8, 2024
9 of 10 checks passed
@wuast94 wuast94 deleted the patch-1 branch October 8, 2024 12:54
@meili-bot meili-bot added the v1.12.0 PRs/issues solved in v1.12.0 released on 2024-12-23 label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement v1.12.0 PRs/issues solved in v1.12.0 released on 2024-12-23
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/meilisearch/meilisearch/pull/4990

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy