Content-Length: 291466 | pFad | https://github.com/meilisearch/meilisearch/pull/5118

5A Change the reserve and grant function to accept a closure by Kerollmops · Pull Request #5118 · meilisearch/meilisearch · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the reserve and grant function to accept a closure #5118

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

Kerollmops
Copy link
Member

This simplifies the usage of the grant and commits it at the right time, just after having written in it.

ManyTheFish
ManyTheFish previously approved these changes Dec 4, 2024
Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link
Contributor

meili-bors bot commented Dec 4, 2024

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link
Contributor

meili-bors bot commented Dec 4, 2024

Stopped waiting for PR status (Github check) without running due to duplicate requests to run. You may check Bors to see that this PR is included in a batch by one of the other requests.

Copy link
Contributor

meili-bors bot commented Dec 4, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 54341c2 into release-v1.12.0 Dec 4, 2024
10 checks passed
@meili-bors meili-bors bot deleted the reserve-and-write-grant branch December 4, 2024 10:47
@meili-bot meili-bot added the v1.12.0 PRs/issues solved in v1.12.0 released on 2024-12-23 label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.12.0 PRs/issues solved in v1.12.0 released on 2024-12-23
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/meilisearch/meilisearch/pull/5118

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy